search

ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

Change interpolation default for `imshow_field()` #149

Closed syhaffert closed 2 years ago

syhaffert commented 2 years ago

Matplotlib had a small change in their default plotting behavior. It changed the default interpolation style to anti-aliased by using bilinear interpolation, see https://github.com/matplotlib/matplotlib/issues/17345 . The default keyword for imshow_field was changed to retain the default plotting style of hcipy.

codecov[bot] commented 2 years ago

Codecov Report

Merging #149 (325a4bc) into master (fa3ea98) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files          94       94           
  Lines        6903     6903           
=======================================
  Hits         5589     5589           
  Misses       1314     1314
Impacted Files Coverage Δ
hcipy/plotting/field.py 80.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ehpor commented 2 years ago

Indeed, this was changed in Matplotlib 3.2.0. See https://matplotlib.org/3.5.3/api/prev_api_changes/api_changes_3.2.0.html?highlight=image%20interpolation#default-image-interpolation