ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

Faster modulated pyramid wavefront sensor #162

Closed syhaffert closed 2 years ago

syhaffert commented 2 years ago

This is the implementation of the faster modulated pwfs as mentioned in #112 . I have added a test to check the new method versus the old version and they agree quite well with each other. The maximum relative error is smaller than 2 percent, and the relative rms of the difference is ~0.2 percent.

codecov[bot] commented 2 years ago

Codecov Report

Merging #162 (d08b5ef) into master (058c473) will increase coverage by 1.41%. The diff coverage is 89.60%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   79.57%   80.99%   +1.41%     
==========================================
  Files          94       95       +1     
  Lines        6503     6986     +483     
==========================================
+ Hits         5175     5658     +483     
  Misses       1328     1328              
Impacted Files Coverage Δ
hcipy/aperture/__init__.py 100.00% <ø> (ø)
hcipy/optics/detector.py 72.46% <ø> (+0.82%) :arrow_up:
hcipy/plotting/field.py 80.00% <ø> (ø)
hcipy/optics/aberration.py 37.83% <50.00%> (ø)
hcipy/optics/fiber.py 67.30% <70.00%> (+2.13%) :arrow_up:
hcipy/coronagraphy/knife_edge.py 71.18% <71.42%> (+49.44%) :arrow_up:
hcipy/version.py 83.33% <81.81%> (+5.55%) :arrow_up:
hcipy/aperture/generic.py 89.43% <82.05%> (-3.23%) :arrow_down:
hcipy/field/coordinates.py 76.84% <92.85%> (+3.59%) :arrow_up:
hcipy/aperture/realistic.py 95.72% <94.16%> (-0.24%) :arrow_down:
... and 47 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ehpor commented 2 years ago

I'll approve once the tests have passed.