search

ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

Very small bug fix in Wavefront class #166

Closed syhaffert closed 1 year ago

syhaffert commented 1 year ago

I found a code breaking typo in the Wavefront class. The wavenumber assignment method used npf.pi instead of np.pi. I fixed this.

codecov[bot] commented 1 year ago

Codecov Report

Merging #166 (d0fbc77) into master (3a6c42f) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files          95       95           
  Lines        7044     7044           
=======================================
  Hits         5685     5685           
  Misses       1359     1359
Impacted Files Coverage Δ
hcipy/optics/wavefront.py 87.16% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

syhaffert commented 1 year ago

probably because nobody uses wavenumbers. at least I know I never use it.