search

ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

Add problem matcher to annotate flake8 errors in PRs. #175

Closed ehpor closed 1 year ago

ehpor commented 1 year ago

Fixes #174 by removing reviewdog as a dependency.

codecov[bot] commented 1 year ago

Codecov Report

Merging #175 (37c56ab) into master (b646ebf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          95       95           
  Lines        7103     7103           
=======================================
  Hits         5744     5744           
  Misses       1359     1359

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ivalaginja commented 1 year ago

Is this supposed to already fix things for the tests on this branch? Asking because they're still waiting for the flake8 status to be reported after all tests finished and passed.

ehpor commented 1 year ago

Is this supposed to already fix things for the tests on this branch? Asking because they're still waiting for the flake8 status to be reported after all tests finished and passed.

I think that flake8 requirements is for reviewdog, which is being disabled by this PR. If so, I should make it optional. I'll look into that now.

FYI, this is a copy of the hicat-package2 problem matcher.

ehpor commented 1 year ago

Unconfirmed, since Github doesn't tell me the source other than "Github Action", but likely that came from reviewdog. I removed it anyway, since the Lint action takes care of that now.