search

ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.
https://hcipy.org
MIT License
91 stars 30 forks source link

FPS changed to duration in imageio dependency #188

Closed ehpor closed 1 year ago

ehpor commented 1 year ago

FPS was removed with imageio 2.28.0. I haven't been able to track down which commit exactly, but both fps and duration have been allowed before, so there is no disadvantage against changing this.

codecov[bot] commented 1 year ago

Codecov Report

Merging #188 (fcb0cd3) into master (088fd96) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          97       97           
  Lines        7266     7266           
=======================================
  Hits         5915     5915           
  Misses       1351     1351
Impacted Files Coverage Δ
hcipy/plotting/animation.py 73.15% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more