Closed ehpor closed 11 months ago
Merging #210 (b54b6a0) into master (5ae0bda) will increase coverage by
0.15%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 81.70% 81.85% +0.15%
==========================================
Files 97 97
Lines 7328 7328
==========================================
+ Hits 5987 5998 +11
+ Misses 1341 1330 -11
Files | Coverage Δ | |
---|---|---|
hcipy/plotting/animation.py | 78.20% <100.00%> (+7.05%) |
:arrow_up: |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
@syhaffert Had to fix merge conflicts. Can you re-approve?
This gets rid of deprecation warnings. Note that we can switch to v3 of the imageio at a later point. Let's be conservative with the versioning for now.
This PR also improves code coverage for animations by testing all three ways that frames can be added to an animation, rather than only the default one.
Fixes https://github.com/ehpor/hcipy/issues/209