Magellan aperture fix - Githubissues

ehpor / hcipy

A framework for performing optical propagation simulations, meant for high contrast imaging, in Python.

https://hcipy.org

MIT License

93 stars 31 forks source link

Magellan aperture fix #237

Closed syhaffert closed 3 weeks ago

syhaffert commented 4 weeks ago

The definition of the Magellan aperture's spiders in hcipy were wrong. I have traced down why the error happened and it's due to misinterpretation of an angle definition. This PR fixes the spiders of the Magellan aperture. This aperture definition has been verified with on-sky pupil images.

I have recreated the Magellan fits file for the test_apertures.py script and I include this new file in the PR.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.04%. Comparing base (0143906) to head (b8f4118). Report is 6 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #237 +/- ## ========================================== - Coverage 82.05% 82.04% -0.02% ========================================== Files 102 102 Lines 7558 7553 -5 ========================================== - Hits 6202 6197 -5 Misses 1356 1356 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ehpor commented 4 weeks ago

A quick screenshot of the verification with on-sky images would be nice, but not required if you're not able to share a screenshot of that data publicly.

Otherwise, this looks good to me and I'll approve once I hear back from you. @syhaffert

syhaffert commented 4 weeks ago

That is a little bit complicated. The on-sky pupil was compared to a manufacture pupil mask. And I compared the new implementation with the design of that pupil mask. And those now match as shown by the figure below.