Remove dual conversion from CompositionComposition and CompositionComponent - Githubissues

ehrbase / fhir-bridge

FHIR Bridge acts as a broker between an HL7 FHIR client and an openEHR server.

31 stars 20 forks source link

Remove dual conversion from CompositionComposition and CompositionComponent #191

Closed subigre closed 3 years ago

subigre commented 3 years ago

Background

The first implementation of the converter API allows of conversions in both directions:

From FHIR to EHR
From EHR to FHIR

The second direction is never used. However it introduces some additional code that might be clean up.

Expected output

Remove all the code and complexity regarding conversion API that it is not needed in the integration flows and Apache Camel composition component.

[ ] Remove the converter from EhrCompositionComponent
[ ] Update the Camel routes to convert the FHIR resource into a EHR composition before calling the composition endpoint.

Success criteria

[ ] Output has been reviewed or presented and has been approved
[ ] Documentation has been updated (Sphinx and Javadoc if applicable)

subigre commented 3 years ago

Done in the following branch https://github.com/ehrbase/fhir-bridge/tree/feature/fix_255_refactoring

subigre commented 3 years ago

Refactoring has been merged in develop