ehrbase / fhir-bridge

FHIR Bridge acts as a broker between an HL7 FHIR client and an openEHR server.
32 stars 20 forks source link

Adjusting failing Integration tests in CircleCI #570

Closed af-pwo closed 2 years ago

af-pwo commented 2 years ago

[ADJUST] Diagnostic Report w/ Observation is a valid ressource, therefore it should check for 201

[DELETE] Unnecessary "prepare" tags

[DELETE] Negative flow tests that tested valid behaviour. Validation was done by cross checking profiles documentation via https://simplifier.net/ForschungsnetzCovid-19/~resources?category=Profile&fhirVersion=R4&sortBy=RankScore_desc

value.quantity - Blood Pressure- invalid values value.quantity - Body Temperature- invalid values value.quantity - Fi02- invalid values value.quantity - Body Height- invalid values valueCodeableConcept.coding[0].code - Pregnancy Status -random string code.coding* - Observation Lab - missing valueCodeableConcept.coding[0].system - History of Travel - random valueCodeableConcept.coding[0].code - History of Travel - random string component[0].code.coding[0].code - History of Travel - random string component[0].code.coding[0].system - History of Travel - random url component[1].code.coding[0].code - History of Travel - random string component[1].code.coding[0].system - History of Travel - random url component[2].code.coding[0].code - History of Travel - random string component[2].code.coding[0].system - History of Travel - random url component[3].code.coding[0].code - History of Travel - random string component[3].code.coding[0].system - History of Travel - random url component[4].code.coding[0].code - History of Travel - random string component[4].code.coding[0].system - History of Travel - random url

[DELETE] Unnecessary Bug Trace - Body Height

[BUG] Unexpected 201 at History if Travel when:

component[0].code.coding[0].system - missing component[1].code.coding[0].system - missing component[2].code.coding[0].system - missing component[3].code.coding[0].system - missing component[4].code.coding[0].system - missing

https://github.com/ehrbase/fhir-bridge/issues/568

This attribute is mandatory according to https://simplifier.net/forschungsnetzcovid-19/historyoftravel. An error should be thrown, when it is missing.

[ADD] Comments to Bug Trace case in History of Travel.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information