search

ehsanMa86 / NACA-4digits-m4

GNU General Public License v3.0
3 stars 1 forks source link

LICENSE file #1

Closed hrobeers closed 5 years ago

hrobeers commented 5 years ago

This script is missing a license file. I'd like to contribute, but I need to know my rights.

Thanks for sharing this!

ehsanMa86 commented 5 years ago

@hrobeers Hello Hans,

I didn't see your comment by now and for some reason github didn't notify me about it. Sorry for my very late reply. The license is GNU GPL3. It is written for OpenFOAM which itself stands for the GPL3 license as well. I am excited to have your contribution and thanks for your time doing it. IT definitely will improve it.

Best regards, Ehsan

hrobeers commented 5 years ago

Cool thanks, I haven't been touching this in a while now. But when I find the time, I'll try to distill the interesting changes for a PR. My improvements were mainly focused on improving the skewness and boundary layer refinement.

I'm also looking at using a medial axis approach (based on voronoi diagrams) to define the block boundaries for improved skewness. But this will require a small C++ program to be added (not purely m4)

ehsanMa86 commented 5 years ago

I am in! So excited. Those are actually good points to implement. Please let me know if I could be helpful at any point. I am more than happy to do it.

Thanks Hans