search

ehsannarmani / ComposeCharts

Animated & Flexible Practical Charts For Jetpack Compose
Apache License 2.0
113 stars 7 forks source link

Indicator position customization #11

Closed LeeWeeder closed 1 day ago

LeeWeeder commented 2 days ago

Introduction

Good day!

I stumbled upon this repo while looking for a line chart library for my app. And well, I'm impressed with how easy it was to implement the API. It is clear and straightforward. I want to thank you first before my real issue. Thank you!

Issue: Feature request

With all that customization, a custom indicator placement would be best. On the use case of my app, I want to position the indicator to the end, instead of at the start.

PS. I already have the implementation of the feature for line and column charts and would like to ask if contributions to your project are allowed 'cause I want to create a pull request.

Sample from my implementation

compose_chart

ehsannarmani commented 2 days ago

@LeeWeeder Hi dear. Thank you so much for your lovely and motivating comment. I glad to hear that the library is useful for you. Definitely yes, you can create your pull request, but the small issue on your implementation is that alignment of indicators text If you make that indicators text alignment left to right it will better.

LeeWeeder commented 2 days ago

Definitely yes, you can create your pull request...

Thank you!

but the small issue on your implementation is that alignment of indicators text If you make that indicators text alignment left to right it will better.

To clarify if I understand your suggestion correctly, does the below image achieve your wanted results? image

ehsannarmani commented 1 day ago

To clarify if I understand your suggestion correctly, does the below image achieve your wanted results?

Yeah exactly, thank you so much.