search

ehubscher / briarproject_390

Concordia University Mini-Capstone (i.e. SOEN 390) project for Team La Famiglia. The Open-Source Project forked is an Android-based secure messaging app called Briar.
Other
4 stars 1 forks source link

Send Photos in Blogs #49 #73

Closed ddicorpo closed 6 years ago

ddicorpo commented 6 years ago

By addind an Image button to the blog view, I was able to add my newly created activity_image_picker *which was added to the base activity) directly to the button so when the button is clicked, it will open up the image selecter. Once you select the image, the response method will encode and decode the base 64 image so it will show up on the screen

Winterhart commented 6 years ago

I have test the feature with two devices and it's not working...

Photo On Device 1 Photo On Device 2

philbeaudry commented 6 years ago

You should also separate your user story into tasks and have one commit for each task. Not commit everything at once. Fox example a subtask could be: Add receiving method to display image, and then you would commit the file changed with this new method with a "#[the number of that atsk]" in the commit message. Good practice is a lot more important then rushed code.

ddicorpo commented 6 years ago

I couldnt split my code but i wrote tasks for each subtask that is associated with this user story. Issue #86 , will add the image button to the blog activity Issue #88 , will allow an image to be selected from the image select window Issue #89 , Will encode the image and send it in the blog activity

Winterhart commented 6 years ago

  1. As I understand the current functions have not been changed (problem upon posting photo to blog: https://i.imgur.com/BjiD54R.png ) however, the current problems will be fixed by Jordan's next pull request... ?

  2. Another concern now.., why is Travis failing on this branch ????

ddicorpo commented 6 years ago

@Winterhart Yes, Jordan's pull request will fix the image issue