search

eibbors / mws-js

Complete Amazon marketplace web services client for Node.js.
86 stars 102 forks source link

Fixed example, added exports #11

Open markdicksonjr opened 10 years ago

markdicksonjr commented 10 years ago

Fixed an example, removed console.log statement, and added some exports for node module usage

danfinlay commented 10 years ago

I like this, I've wanted to add the various components to the main module for a long time.

danfinlay commented 10 years ago

I swear I've submitted that same patch before and it always got rejected. I believe it's designed to be "assembled by the user", maybe for RAM conservation? I don't know, I don't agree with it.

markdicksonjr commented 10 years ago

Same here. I think this is the only node module I've ever had to modify the source for in order to make it remotely usable.

markdicksonjr commented 10 years ago

It looks like he has a more recent branch that hasn't been merged/rebased to master. Maybe that has something to do with it?

danfinlay commented 10 years ago

I'm pretty sure his branch is more about a large refactor. Several people have branches that do essentially what you've just done. Unfortunately he routinely closes these issues/pull requests, so new users have to find this out for themselves over and over.

ondreian commented 10 years ago

@flyswatter This is exactly what I have done. Maybe someone should fork it and add these changes/features/upgrades/bug fixes to a different module based on this one?

danfinlay commented 10 years ago

You're asking me? Go npm publish if you'd like, it won't hurt, make sure to mention that it fixes some confusion from this module in the npm readme.

jvgeee commented 8 years ago

@flyswatter @ondreian What did you guys end up using for MWS? Any repos I can look at? It's dry out here...

danfinlay commented 8 years ago

I used this, it works, I just had to import its internal modules to make it useful.

You could pull this proposed branch if you wanted those modules exposed externally.

ondreian commented 8 years ago

@jascination I patched my own version, there were several inconsistencies with the way this one handles a variety of MWS data structures, as well as the exports problem that @flyswatter mentioned.

It does seem like we're all duplicating a lot of work though.

jvgeee commented 8 years ago

@ondreian Do you have a public repo I could take a look at? Would be a great help. I'm using this one at the moment but it's unfinished.

ondreian commented 8 years ago

It was for an old now deprecated microservice, i'll double check if I still have it handy (I should), and publish it somewhere.

ondreian commented 8 years ago

@jascination sorry it took me so long to get back to you about this, I didn't find it, and I'm not entirely sure what happened to it, and it seems all of the old instances that had it are gone since we stopped doing business on Amazon. Wish I had better news.