Closed osbornjd closed 8 months ago
Opened a PR upstream for which this can eventually take advantage of https://github.com/key4hep/EDM4hep/pull/248
@wdconinc this is ready to be merged now once we update to the new edm4hep version with https://github.com/key4hep/EDM4hep/pull/248 merged. The CI here will naturally fail until we update edm4hep versions.
Briefly, what does this PR introduce?
This PR modifies the vertex EDM to contain 4D information, which is going to be needed in our streaming readout environment to separate pile up from physics bunch crossings.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Discussed in S&C meeting on the 18th of October here.
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
It changes the vertex object for which the vertexing algorithm in EICRecon will need to be updated. This should be a simple fix since nothing else depends on the vertexing algorithm at the moment as it is still under development.