Break up `Cluster::clusterShape` into named fields

eic / EDM4eic

A data model for EIC defined with podio and based on EDM4hep.

https://eic.github.io/EDM4eic/

GNU Lesser General Public License v3.0

3 stars 4 forks source link

Open veprbl opened 3 months ago

veprbl commented 3 months ago

The clusterShape vector member had become a dumping ground for additional values that bypass EDM review procedure https://github.com/eic/EDM4eic/blob/f21b3881034524b312921b286081ddfdbe45cff5/edm4eic.yaml#L292 In addition to that, accessing values by index is confusing to our users. We should migrate away from this approach.

ruse-traveler commented 2 months ago

I'd like to second this: it's a bit embarrassing, but I keep forgetting we have this information stored 😓