dRICH photon angle versus phi for aerogel is suspicious after noise injection

chchatte92 commented 1 year ago

Environment: (where does this bug occur, have you tried other environments)

Which branch (often main for latest released): Main
Which version (or HEAD for the most recent on git): N/A
Any specific OS or system where the issue occurs? No
Any special versions of ROOT or Geant4? No

Steps to reproduce: (give a step by step account of how to trigger the bug)

Reconstruct the dRICH simulation with config/recon_irt_noise.yaml that can be found in drich-dev This will introduce a white noise for the sensor surface. The noise is uniformly added.

Expected Result: (what do you expect when you execute the steps above)

The expectation is the uniform noise will go linearly over larger surface. This indicates the amount of noise we will observe for aerogel will be larger than the gaseous rings over the entire azimuthal distribution of SPE Cherenkov angle distribution.

Actual Result: (what do you get when you execute the steps above)

Gas photo-electrons show the tendency. (Expectation matched)
In merged case the tendency is also there. (Expectation matched)
In case of Aerogel it is missing. (Dubious) Image of gas: Image of merged PID: Image of Aerogel:

chchatte92 commented 1 year ago

@c-dilks if you notice the entries for merged cases that is exactly the sum of Gas and Aerogel entries. The problem is, to understand how much is the noise under the aerogel peak?

chchatte92 commented 1 year ago

The yellow filled distribution is SPE angular distribution w/o injected noise. Definitely, with added noise the distribution has got fattened. But, what bothers me, the shape. Will the estimation of the background under the peak be an underestimation?

chchatte92 commented 1 year ago

For the gas situation is like this: This is a shape I would have expected also for the aerogel

c-dilks commented 1 year ago

Reconstruct the dRICH simulation with config/recon_irt_noise.yaml that can be found in drich-dev

Or run with -PDRICH:DRICHRawHits:enableNoise=true for those who don't use the drich-dev parameter config files.

The default values are set here: https://github.com/eic/EICrecon/blob/a8cd3a9617d0b3e09c01427b4a889f4787e02599/src/detectors/DRICH/DRICH.cc#L42-L44

chchatte92 commented 1 year ago

https://github.com/eic/EICrecon/issues/1026#issuecomment-1737644238 Thanks @c-dilks , I forgot to mention that option.

chchatte92 commented 10 months ago

@c-dilks our student Tiziano made a quite a bit of progress on this issue.

eic / EICrecon