Open ShujieL opened 1 year ago
The MultiTrajectoryHelper identify a shared hit by "SharedHitFlag". But CKF algorithm (CombinatorialKalmanFilter.hpp) never set this flag, that's why EICrecon always pick up 0. We can either add a piece of code in MultitrajectoryHelper (ACTS) or CKFtracking (EICrecon) that loops over hits to find shared hits . @wdconinc any thoughts?
Environment: (where does this bug occur, have you tried other environments)
main
for latest released): mainHEAD
for the most recent on git): HEADSteps to reproduce: (give a step by step account of how to trigger the bug)
Minjung Kim noticed that in any EICrecon output, the trajectory.nSharedHits is always 0, though the trajectories are obviously duplicated. see below:
Expected Result: (what do you expect when you execute the steps above)
The nshared hits should have the value set in CKFtracking.cc: https://github.com/eic/EICrecon/blob/f8e335686455506ee10e537cb5c5b8b1d15bf677/src/algorithms/tracking/CKFTracking.cc#L238