search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

TrackProjector writes spherical momentum, should be cartesian #1267

Open wdconinc opened 9 months ago

wdconinc commented 9 months ago

What's less clear is whether momentum and momentumError are correct. EDM4eic implies these are cartesian components, not q/p, theta, phi as is done here. In that case, we do need the conversion to free. @jdbrice or @tylerkutz are you using momentum and/or momentumError from these TrackPoints? Would it break your workflows or can we just change this to conform?

Originally posted by @wdconinc in https://github.com/eic/EICrecon/issues/1252#issuecomment-1912755996

tylerkutz commented 9 months ago

Currently all of our track projections are based on src/algorithms/tracking/TrackPropagation.cc.

At any rate, I am not currently using the projected momentum or momentumError, and would have no problem with the change you suggested.

wdconinc commented 9 months ago

Both TrackPropagation and TrackProjector have the same problem because they do the same and one was copied from the other...