eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

hotfix: rm InclusiveKinematicsML from default output collections #1390

Closed wdconinc closed 4 months ago

wdconinc commented 4 months ago

Briefly, what does this PR introduce?

This PR aims to hotfix hanging eicrecon when InclusiveKinematicsML is included in output collections. Disabling the collection, while debugging.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes, removes InclusiveKinematicsML again.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1390

wdconinc commented 4 months ago

This doesn't seem necessary anymore. Pipelines are succeeding.

wdconinc commented 4 months ago

Force-merging because eic_container now succeeds on this branch but continues to fail the benchmarks for main.