eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

feat: convert RichTrack factory to JOmniFactory #1395

Closed wdconinc closed 4 months ago

wdconinc commented 4 months ago

Briefly, what does this PR introduce?

This PR converts the RichTrack_factory to JOmniFactory. This is one of the holdouts for this conversion since it does so much in terms of setting up planes, including parsing of collection names. Well, that's a thing of the past now.

What is lost compared to previously?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Yes, if you were relying on the command line parameter DRICH:gas:numPlanes=10.

Does this PR change default behavior?

Yes, if you were relying on the command line parameter DRICH:gas:numPlanes=10.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1395

wdconinc commented 4 months ago

Asked for early reviews, even though this is currently killing the DRICH reconstruction, but that's just a temporary issue.

wdconinc commented 4 months ago

Only diff now: image

veprbl commented 4 months ago

https://github.com/eic/EICrecon/actions/runs/8855484300/job/24333764925#step:8:225 Must be due to some exception thrown.

veprbl commented 4 months ago

https://github.com/JeffersonLab/JANA2/issues/274