Closed wdconinc closed 4 months ago
Asked for early reviews, even though this is currently killing the DRICH reconstruction, but that's just a temporary issue.
Only diff now:
https://github.com/eic/EICrecon/actions/runs/8855484300/job/24333764925#step:8:225 Must be due to some exception thrown.
Briefly, what does this PR introduce?
This PR converts the RichTrack_factory to JOmniFactory. This is one of the holdouts for this conversion since it does so much in terms of setting up planes, including parsing of collection names. Well, that's a thing of the past now.
What is lost compared to previously?
eicrecon -PDRICH:gas:numPlanes=10
won't work anymore and this needs to be provided through the plugin. If really required, this can be brought back sinceDRICH::InitPlugin
has access to theJApplication*
pointer, but I'd rather not set a precedent that it's ok to define command line arguments there...What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Yes, if you were relying on the command line parameter
DRICH:gas:numPlanes=10
.Does this PR change default behavior?
Yes, if you were relying on the command line parameter
DRICH:gas:numPlanes=10
.