eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

linux-eic-shell.yml: run trigger-container for when merge_group is tested #1397

Closed veprbl closed 4 months ago

veprbl commented 4 months ago

Since we now require container build to pass as a requirement for successful merge to main, we need to actually attempt to build it.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1397

veprbl commented 4 months ago

@simonge Can you approve this? This is safe (tm).

veprbl commented 4 months ago

I've changed timeout from 3h to 6h. Let's try again.

veprbl commented 4 months ago

Not going to work https://github.com/eic/EICrecon/actions/runs/8819319775/job/24210808245 What we use in eic/epic does not require a synced branch

veprbl commented 4 months ago

This needs https://github.com/eic/detector_benchmarks/blob/16fd651e6f9ce0c670eefe047d337cbe7bbc8296/.github/workflows/mirror.yaml#L19-L29 plus, if I remember correctly, also merge group ref somehow didn't work, so a fix is needed.

I will disable the container requirement for now.

veprbl commented 4 months ago

@wdconinc Let's try again, since, I think, I resolved the 404 issue. Please, approve.

veprbl commented 4 months ago

We require eicweb benchmarks for eic/epic repository merges, yet somehow here it failed. In addition to container build failures and slowness, I don't think this is reliable enough to enable this now.