eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

Switch SiliconTrackerDigi RNG to RandomSvc [DO NOT MERGE] #1398

Closed kkauder closed 4 months ago

kkauder commented 4 months ago

Briefly, what does this PR introduce?

Switch RNG to RandomSvc

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Not really, should be faster, lighter, and conform better to reproducibility.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1398

wdconinc commented 4 months ago

Do you feel like switching PhotoMultiplierHitDigi over as well? It's essentially the same thing (even if @c-dilks may have added some more layers around it). https://github.com/eic/EICrecon/blob/14bc49be8ad313ab2311fbbc08163d2cf81dfab7/src/algorithms/digi/PhotoMultiplierHitDigi.h#L83

kkauder commented 4 months ago

Do you feel like switching PhotoMultiplierHitDigi over as well? It's essentially the same thing (even if @c-dilks may have added some more layers around it).

https://github.com/eic/EICrecon/blob/14bc49be8ad313ab2311fbbc08163d2cf81dfab7/src/algorithms/digi/PhotoMultiplierHitDigi.h#L83

Sure! Don't approve this one until that PR is online (I won't do it today and that way I'll remember)

wdconinc commented 4 months ago

Closing for now for operational reasons. We can reopen later.