eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

added a 'neutron reconstruction' algorithm which creates a neutron candidate that merges all clusters in a given bank #1404

Closed sebouh137 closed 4 months ago

sebouh137 commented 4 months ago

Briefly, what does this PR introduce?

Adds a cluster-merging algorithm that creates a "neutron candidate" (of type ReconstructedParticle) that merges all clusters in a given bank together.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

Yes, changes ZDC reconstruction to use ImagingTopo clustering instead of island clustering. Also tweaked the ImagingTopo algorithm parameters that are used in ZDC recon

wdconinc commented 4 months ago

@sebouh137 Please fix merge conflicts.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1404

sebouh137 commented 4 months ago

@sebouh137 Please fix merge conflicts.

Fixed

sebouh137 commented 4 months ago

Thanks for the development, Sebouh! I have a minor fix suggested on the code itself, but I have some larger conceptual suggestions:

  • I think this might make more sense alongside the reco algorithms since this is taking the final step from detector objects (topoclusters) to physics objects (neutron candidates) Ok, I have moved it there.
  • I would suggest renaming this to something like FarForwardNeutronReconstrution since neutrons will also be reconstructed elsewhere in ePIC with very different algorithms. Ok, I have changed the name.