search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

Created algorithm and factory for calculating hadronic final state variables #1405

Closed tylerkutz closed 4 months ago

tylerkutz commented 4 months ago

Briefly, what does this PR introduce?

This adds and algorithm and corresponding factory for calculating hadronic final state variables. Since this uses a new EDM4eic data type not included in major release 5, the algorithm is only called for major release >= 6.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

tylerkutz commented 4 months ago

Thanks @veprbl , I agree that I had left out some necessary guards. Have added them now (not yet pushed though).

I'm having a different problem now. When I compile against my version of EDM4eic and lower the EDM4EIC_VERSION_MAJOR requirement to 5, the algorithm still isn't called...currently trying to figure out why.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1405

tylerkutz commented 4 months ago

@veprbl Pushed with additional guards. Passes build checks now.

veprbl commented 4 months ago

EDM4eic 6 should be in the nightly now, let's see how that fares.

veprbl commented 4 months ago

(Tested that the values are indeed filled)