search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

Separate tracking and PID factories, use algorithms interface #1417

Closed veprbl closed 4 months ago

veprbl commented 4 months ago

The original approach in #829 was to add more functionality into a single factory. This pushes back on that by separating the two responsibilities into two algorithms. This should improve modularity. This also converts algorithms to the algorithms interface. The factory code is rewritten from scratch and licensed to LGPL3.

veprbl commented 4 months ago

Assuming this started with a straightforward cp from src/algorithms/pid/ParticlesWithPID.cc into src/algorithms/tracking/ParticlesWithTruthPID.cc, I didn't carefully look at that removed lines in the former and added lines in the latter.

Yes, the splitting was quite clean, I'm not sure why this had to be originally combined.

veprbl commented 4 months ago

collect-docs is broken, but capybara report is clean now: https://veprbl.github.io/capybara-reports/c75e9e7160558ec6b929117b464291f5/

github-actions[bot] commented 4 months ago

Capybara summary for PR 1417