eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

feat: convert IrtCherenkovParticleID factory to JOmniFactory #1418

Closed wdconinc closed 4 months ago

wdconinc commented 4 months ago

Briefly, what does this PR introduce?

This PR converts the IrtCherenkovParticleID to JOmnifactory, and the IrtCherenkovParticleID algorithm to the algorithms interface.

Because the IrtCherenkovParticleID factory was doing some parsing of collection names, there is less flexibility for now. In particular, for now, the IrtCherenkovParticleID factory temporarily hardcodes the DRICH as the RichGeo system.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1418

wdconinc commented 4 months ago

Nice!

Also removes all particle ID ...

ruse-traveler commented 4 months ago

Also removes all particle ID ...

Whoops! Should've checked the capybara... 😓

wdconinc commented 4 months ago

No diffs.