fix(ci): ubsan with silence_unsigned_overflow=1 - Githubissues

eic / EICrecon

EIC Reconstruction - JANA based

https://eic.github.io/EICrecon

GNU Lesser General Public License v3.0

6 stars 27 forks source link

fix(ci): ubsan with silence_unsigned_overflow=1 #1424

Closed wdconinc closed 4 months ago

wdconinc commented 4 months ago

Briefly, what does this PR introduce?

This PR suppresses unsigned integer overflow warnings by UBSan. These are virtually always in basic_string.h due to string comparisons, e.g. https://github.com/eic/EICrecon/actions/runs/8976184643/job/24652936018#step:8:125. They are noisy and detract from other UB, in particular when they appear on line 1.

What kind of change does this PR introduce?

[x] Bug fix (issue #__)
[ ] New feature (issue #__)
[ ] Documentation update
[ ] Other: __

Please check if this PR fulfills the following:

[ ] Tests for the changes have been added
[ ] Documentation has been added / updated
[ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.