eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 26 forks source link

fix: don't double-define logger LogLevel parameters #1436

Closed wdconinc closed 2 months ago

wdconinc commented 2 months ago

Briefly, what does this PR introduce?

The Log_service::logger(name) call defines name:LogLevel already, so callers don't need to do this anymore. That removes the need for SpdlogExtensions.h includes in factories.

This PR removes the double defines, removes the headers, and also unifies the Acts loggers, so we don't have one for init and one for regular.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 2 months ago

Capybara summary for PR 1436

wdconinc commented 2 months ago

Tested with:

bin/eicrecon -Prichgeo:LogLevel=trace ../../sim_dis_18x275_minQ2\=1000_craterlake.edm4hep.root 
bin/eicrecon -Pacts:LogLevel=trace ../../sim_dis_18x275_minQ2\=1000_craterlake.edm4hep.root 
bin/eicrecon -PBEMC:EcalBarrelScFiClusters:LogLevel=trace ../../sim_dis_18x275_minQ2\=1000_craterlake.edm4hep.root 

All of which still get registered correctly and produce trace output. (Untested by this: benchmarks, tests, processors.)