search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 26 forks source link

LOWQ2: link to algorithms_fardetectors_library #1440

Closed veprbl closed 2 months ago

veprbl commented 2 months ago

It does work, since it is already loaded by other plugins

grep -r algorithms_fardetectors_library src
src/tests/algorithms_test/CMakeLists.txt:          algorithms_fardetectors_library
src/detectors/RPOTS/CMakeLists.txt:plugin_link_libraries(${PLUGIN_NAME} algorithms_fardetectors_library)
src/detectors/FOFFMTRK/CMakeLists.txt:plugin_link_libraries(${PLUGIN_NAME} algorithms_fardetectors_library)

but should be a good idea to have this explicit.

veprbl commented 2 months ago

With benchmarks broken, I'm not sure if this needs to be a part of the release. FWIW I'm able to see this issue in singularity on SDCC.

veprbl commented 2 months ago

Nevermind. This doesn't fix anything. My issue was that in the container you need to set LD_LIBRARY_PATH=$PWD/install/lib:$LD_LIBRARY_PATH to not get a mishmash of different libraries. I've edited the description to reflect the new understanding.

github-actions[bot] commented 2 months ago

Capybara summary for PR 1440

simonge commented 2 months ago

This is already in 266-integrate-lowq2-tagger-reconstruction. Not sure why I hadn't included it in the earlier branches.