search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

PIDLookup: do not copy track sign into ReconstructedParticle's PDG field #1442

Closed veprbl closed 5 months ago

veprbl commented 5 months ago

This appears to be inconsistent with MCParticle's PDG, where codes are positive.

This was discovered in benchmark https://github.com/eic/physics_benchmarks/blob/cd616f2a92e5d59f9e94c27d9ad0a1b8c18daeef/benchmarks/dis/analysis/truth_reconstruction.py#L56

Fixes: https://github.com/eic/physics_benchmarks/issues/7

github-actions[bot] commented 5 months ago

Capybara summary for PR 1442