eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

PIDLookup: fix incorrect PDG convention - electron should not be -11 #1443

Closed veprbl closed 5 months ago

veprbl commented 5 months ago

Second iteration on #1442. None of the hadrons should be affected by convention, but electron is one of exceptions.

This was discovered in benchmark https://github.com/eic/physics_benchmarks/blob/cd616f2a92e5d59f9e94c27d9ad0a1b8c18daeef/benchmarks/dis/analysis/truth_reconstruction.py#L56

Fixes: https://github.com/eic/physics_benchmarks/issues/7

github-actions[bot] commented 5 months ago

Capybara summary for PR 1443

epic-capybara commented 5 months ago

Backport failed for v1.13, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v1.13
git worktree add -d .worktree/backport-1443-to-v1.13 origin/v1.13
cd .worktree/backport-1443-to-v1.13
git switch --create backport-1443-to-v1.13
git cherry-pick -x 5a8d5021f7f5b3e5af06b26cf7ef3c710306fdae df3fe299e5b2789b278e9ae154c3a26351b21559 6f7cd692b60cd8d81d1885977c1a34f07f99f496