search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

feat: set track relation for calorimeter and DRICH propagations #1450

Closed wdconinc closed 4 months ago

wdconinc commented 4 months ago

Briefly, what does this PR introduce?

The tracks propagated to the calorimeter surfaces and the DRICH aerogel and gas surfaces did not contain the relation to the track.

This PR adds the track relations to CalorimeterTrackProjections and the DRICH{Aerogel,Gas}Tracks collections.

Note the methodology here. We don't use edm4eic::Tracks to do the propagation, so this here relies on keeping the order in the edm4eic::Tracks and ActsExamples::Trajectories.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 4 months ago

Capybara summary for PR 1450

wdconinc commented 4 months ago

Looks sensible...

Screenshot_20240511-105302

wdconinc commented 4 months ago

Both e and pi singles are missing 4 of 100 entries, https://eicrecon.epic-eic.org/pr/1450/capybara/rec_e_1GeV_20GeV_craterlake/index.html#_CalorimeterTrackProjections_track

I could imagine this is simply projections that don't end up anywhere. The same 4 of 100 don't have points to begin with, https://eicrecon.epic-eic.org/pr/1450/capybara/rec_e_1GeV_20GeV_craterlake/index.html#CalorimeterTrackProjections

tylerkutz commented 4 months ago

This looks good and the I agree the resulting numbers are reasonable (at least based on my own studies of the track propagations).

Just to confirm, this solution assumes the same ordering of the edm4eic::TrackCollection and the vector of ActsExamples::Trajectoriess? (As you mentioned in the reconstruction meeting).

wdconinc commented 4 months ago

Just to confirm, this solution assumes the same ordering of the edm4eic::TrackCollection and the vector of ActsExamples::Trajectoriess? (As you mentioned in the reconstruction meeting).

Yes, it assumes the thing I've told people not to assume. For now, it's valid; it won't be when we go to more complex running strategies. By then we will have phased this out.