This PR removes all the links from every factory to podio::Frame, and all links from the JEventProcessorPODIO to every factory. These are not usually necessary and cause a lot of visual noise.
Because multifactory outputs are not strongly connected with rank=same in the janadot output, we can use explicit grouping to make sure these are not placed far away from each other. Instead of doing this on just collection and corresponding assocations, we introduce groups per function.
After tweaking the groups (regrettably by hand since our directory structure is not very useful), we get a relatively readable diagram again.
What kind of change does this PR introduce?
[x] Bug fix (issue #__)
[ ] New feature (issue #__)
[ ] Documentation update
[ ] Other: __
Please check if this PR fulfills the following:
[ ] Tests for the changes have been added
[ ] Documentation has been added / updated
[ ] Changes have been communicated to collaborators
Does this PR introduce breaking changes? What changes might users need to make to their code?
Briefly, what does this PR introduce?
This PR removes all the links from every factory to
podio::Frame
, and all links from theJEventProcessorPODIO
to every factory. These are not usually necessary and cause a lot of visual noise.Before: (https://github.com/eic/EICrecon/actions/runs/9082766317)![rec_dis_5x41_minQ2=0_craterlake](https://github.com/eic/EICrecon/assets/4656391/fac20c84-2c44-4a92-b7fd-5d330621ae10)
After: (https://github.com/eic/EICrecon/actions/runs/9084397114)![rec_dis_5x41_minQ2=0_craterlake](https://github.com/eic/EICrecon/assets/4656391/657d5933-f663-4f7c-a968-a61511e2164f)
Because multifactory outputs are not strongly connected with rank=same in the janadot output, we can use explicit grouping to make sure these are not placed far away from each other. Instead of doing this on just collection and corresponding assocations, we introduce groups per function.![rec_dis_5x41_minQ2=0_craterlake](https://github.com/eic/EICrecon/assets/4656391/5068e7f3-41e1-4786-a5cb-03aa447833a8)
After tweaking the groups (regrettably by hand since our directory structure is not very useful), we get a relatively readable diagram again.![jana](https://github.com/eic/EICrecon/assets/4656391/6db7c1e8-7390-4825-8ff4-a51e4c7fb271)
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.