eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 26 forks source link

fix(ci): slim down dot output #1452

Closed wdconinc closed 2 months ago

wdconinc commented 2 months ago

Briefly, what does this PR introduce?

This PR removes all the links from every factory to podio::Frame, and all links from the JEventProcessorPODIO to every factory. These are not usually necessary and cause a lot of visual noise.

Before: (https://github.com/eic/EICrecon/actions/runs/9082766317) rec_dis_5x41_minQ2=0_craterlake

After: (https://github.com/eic/EICrecon/actions/runs/9084397114) rec_dis_5x41_minQ2=0_craterlake

Because multifactory outputs are not strongly connected with rank=same in the janadot output, we can use explicit grouping to make sure these are not placed far away from each other. Instead of doing this on just collection and corresponding assocations, we introduce groups per function. rec_dis_5x41_minQ2=0_craterlake

After tweaking the groups (regrettably by hand since our directory structure is not very useful), we get a relatively readable diagram again. jana

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 2 months ago

Capybara summary for PR 1452