search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 26 forks source link

Add low Q2 NN inference #1467

Closed simonge closed 1 month ago

simonge commented 2 months ago

Briefly, what does this PR introduce?

Adds the inference step, reconstructing the initial momentum of the low-Q2 electrons from their tracks. This relies on https://github.com/eic/epic-data/pull/17 to add the inference model to the expected default location (so far tested by manually copying the file there).

This will be followed by the final PR which finally injects the low-Q2 electron tracks into the main tracking data flow so they get treated equally by the following algorithms.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

simonge commented 1 month ago

The build-docs is complaining that none of the capybara files are available. The reconstruction CI steps cannot find the previous versions for capybara to compare against. I can't see anything in this PR which could have influenced this?

veprbl commented 1 month ago

I've restarted CI on main (looks like it was cancelled?), that should fix it.

github-actions[bot] commented 1 month ago

Capybara summary for PR 1467

simonge commented 1 month ago

The whole workflow seems to be a bit unstable at the moment. I might be wrong in some of this but, seemingly random jobs have been skipped, sometimes taken much longer than usual or been unable to find artefacts from either main or which have just been produced.

I had to rerun starting from later steps to get to the end.