search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 24 forks source link

fix(ci): use correct detector-info hash #1489

Closed wdconinc closed 1 month ago

wdconinc commented 1 month ago

Briefly, what does this PR introduce?

This PR fixes how we determine the detector hash that tells us when we have to rerun the npsim part of the pipeline to make sure our simulation and reconstruction are using the same geometry.

Due to changes in the containers (epic now in spack), the previous approach returns nothing for any geometry

grep epic/nightly /cvmfs/singularity.opensciencegrid.org/eicweb/jug_xl\:nightly/etc/jug_info | sed 's/.*: .*-\(.*\)/hash=\1/g'

The new approach takes the hash of, e.g.

$ grep ' epic@' /cvmfs/singularity.opensciencegrid.org/eicweb/jug_xl:nightly/etc/jug_info
 - [+] gqyaoru epic@23.10.0
 - [+] l6jmpez epic@23.11.0
 - [+] m4h7dpf epic@23.12.0
 - [+] malsskd epic@24.02.0
 - [+] ey2eyus epic@24.02.1
 - [+] wtzurj6 epic@24.03.0
 - [+] 3bqnqno epic@24.03.1
 - [+] ybvec7w epic@24.04.0
 - [+] nterp3c epic@24.05.0
 - [+] t6777ht epic@24.05.2
 - [+] u6ap7qw epic@git.8c40e0ba534f9c3bd7cac3bfcbb46c785b368643=main
 - gqyaoru epic@23.10.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - l6jmpez epic@23.11.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - m4h7dpf epic@23.12.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - malsskd epic@24.02.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - ey2eyus epic@24.02.1~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - wtzurj6 epic@24.03.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - 3bqnqno epic@24.03.1~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - ybvec7w epic@24.04.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - nterp3c epic@24.05.0~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - t6777ht epic@24.05.2~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make
 - u6ap7qw epic@git.8c40e0ba534f9c3bd7cac3bfcbb46c785b368643=main~ipo artifacts=epic_craterlake build_system=cmake build_type=Release generator=make

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 1 month ago

Capybara summary for PR 1489