Closed sebouh137 closed 3 months ago
Let's wait for geometry change to be merged.
Let's wait for geometry change to be merged.
Ok, I see that you've approved the geometry change. Thanks for that. As soon as the checks pass (I just merged in all of the changes from the main branch), I assume we'll be ready to merge this change as well.
Changed sampling fraction for the insert from 0.98% to 2.59% in order to match the change from mixed W + Fe absorbers to all Fe absorbers (see pull request https://github.com/eic/epic/pull/744 in the epic repository)
Briefly, what does this PR introduce?
Changes the sampling fraction for reconstructing hits in the calorimeter insert to match a change in the materials used in the detector
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
yes. Users must use the updated detector geometry: https://github.com/eic/epic/pull/744
Does this PR change default behavior?
yes.