search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 24 forks source link

fix: ensure USE_ONNX=OFF can compile #1513

Closed wdconinc closed 2 weeks ago

wdconinc commented 2 weeks ago

Briefly, what does this PR introduce?

This PR passes USE_ONNX as a compile definition and guards use of ONNX functionality with an ifdef.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

wdconinc commented 2 weeks ago

This approach continues to break downstream compilation due to the use of the ONNX functionality in headers. We should promote USE_ONNX as a target compile definition attached to one of our installed targets or somehow propagate USE_ONNX through EICreconConfig.cmake. This is similar to the issue in JANA2 with HAVE_PODIO.

I'm considering this issue out of scope for this PR which just aims to fix compilation within EICrecon.

github-actions[bot] commented 2 weeks ago

Capybara summary for PR 1513