eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 24 forks source link

fix: don't require Acts::{Identification,TGeo} component, but require Json #1520

Closed wdconinc closed 5 days ago

wdconinc commented 1 week ago

Briefly, what does this PR introduce?

We do not use the Acts Identification and TGeo plugins, but we do need the Acts Json plugin.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 1 week ago

Capybara summary for PR 1520

wdconinc commented 1 week ago

I used this patch extensively over the past few days while testing Acts versions from 31 through 36, and didn't encounter any issues.

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud