eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 24 forks source link

fix: require AlgorithmsInit_service in IrtCherenkovParticleID for ParticleSvc #1522

Closed wdconinc closed 1 week ago

wdconinc commented 1 week ago

Briefly, what does this PR introduce?

This PR should(?) fix the drich_fixed_eta reconstruction benchmark error in https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/jobs/3441830. Unfortunately I can't reproduce the issue locally (it always works). The CI pipeline will have to tell if this works...

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 1 week ago

Capybara summary for PR 1522

wdconinc commented 1 week ago

Succeeds in https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/jobs/3451184 (default is specified version, i.e. latest stable in regular build or branch in PR).