eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
5 stars 24 forks source link

feat: support Acts versions from v31 up to v36 (to be released) #1525

Open wdconinc opened 1 week ago

wdconinc commented 1 week ago

Briefly, what does this PR introduce?

This adapts our tracking algorithms to any Acts version between v31 and v36 (to be released, so additional refactors may hit the Acts main branch that would need porting).

The commits in this branch are topologically ordered with reference to the commit message title, Acts PR number, and version validity. All commits compile individually, but no event-for-event validation has been performed.

The support for mulitple versions is done by somewhat extensive use of preprocessor directives based on Acts_VERSION_MAJOR.

Builds with:

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

github-actions[bot] commented 1 week ago

Capybara summary for PR 1525

wdconinc commented 1 week ago

The (short term) scope for merging here is:

The next steps are:

Out of scope for this PR are:

This enables the possibility for validation from the actual validation, and hopefully leads to a faster workflow in the long run.

wdconinc commented 6 days ago

Two mistakes corrected and force pushed.

Both of the following ifs should apply for Acts_VERSION_MAJOR >= 33, not 32.

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wdconinc commented 6 days ago

No major diffs (but many minor diffs): https://wdconinc.github.io/capybara-reports/1c667510d01aed2d228e74ea6e574252/