Open RaiqaRasool opened 1 month ago
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Please retry analysis of this Pull-Request directly on SonarCloud
Was that all that was needed? In transit but I thought it wasn't that easy...
The goal is to find out. I'm also resuscitating #1069 as part of this effort.
Briefly, what does this PR introduce?
This PR introduces changes to the
JEventProcessorPODIO::Process
to limit the scope of locks, enabling the use of JANA's parallelism and improving the performance by avoiding unnecessary serialization of events.What kind of change does this PR introduce?
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, this PR does not introduce breaking changes. Users do not need to make any changes to their existing code.
Does this PR change default behavior?
Yes, the PR changes the default behavior by enabling JANA's parallelism through the use of
std::unique_lock
withstd::defer_lock
, allowing sections of the code to run in parallel rather than in sequence. The main change is the introduction ofstd::unique_lock
withstd::defer_lock
to manage the mutex locking more precisely, allowing for better parallelism by unlocking the mutex during non-critical sections of the code.