search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 27 forks source link

lowered the amount of distance neighbor hits in topoclustering in the ZDC #1532

Closed sebouh137 closed 1 month ago

sebouh137 commented 1 month ago

Briefly, what does this PR introduce?

Redefines neighboring subcell hits in the ZDC (in the context of topo clustering) to be the nearest neighbors only for hits in the same layer, and the same position for hits in adjacent layers. This change reduces the cases where showers from different particles are merged into a single cluster

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

no.

Does this PR change default behavior?

yes. Changes the default behavior of the topo clustering in the ZDC

github-actions[bot] commented 1 month ago

Capybara summary for PR 1532

veprbl commented 1 month ago

@sebouh137 Is this ready? Can you address the review question?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sebouh137 commented 1 month ago

@sebouh137 Is this ready? Can you address the review question?

Hi @veprbl I determined that this change was necessary in the context of the Lambda benchmark in the ZDC, https://github.com/eic/physics_benchmarks/pull/19 , since I was seeing a lot of events where clusters were being merged together when they shouldn't be merging (causing a lot of events to have only one cluster, when they should have two or ideally three if the two photons's and the neutron's showers can be distinguished from one another). I can make some plots with and without this change to the EICrecon

veprbl commented 1 month ago

Feel free to post figures as they become available.