BTOF,DRICH,DIRC,PFRICH: unroll PID LUT factory initialization loops

eic / EICrecon

EIC Reconstruction - JANA based

https://eic.github.io/EICrecon

GNU Lesser General Public License v3.0

6 stars 27 forks source link

BTOF,DRICH,DIRC,PFRICH: unroll PID LUT factory initialization loops #1536

Closed veprbl closed 1 month ago

veprbl commented 1 month ago

This is to help developers to find the code using simple search.

github-actions[bot] commented 1 month ago

Capybara summary for PR 1536

rec_dis_10x100_minQ2=0_craterlake
rec_dis_10x100_minQ2=1000_craterlake_tracking_only
rec_dis_18x275_minQ2=0_craterlake
rec_dis_18x275_minQ2=1000_craterlake
rec_dis_5x41_minQ2=0_craterlake
rec_e_1GeV_20GeV_craterlake
rec_pi_1GeV_20GeV_craterlake ^{_{Last updated 2024-07-28T19:48-04:00 6ab80357be6aec0cd1bf1f99a54b7e89987aff2c}}

wdconinc commented 1 month ago

I think this programmatic creating of collection names to save a repeat call is obscuring quite a lot, and makes grepping ineffective. Adding the comment is a bandaid, and of course I like bandaids to stop the bleeding but I also want the patient to stop playing with sharp knives.

veprbl commented 1 month ago

I agree, this is now addressed.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud