eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 28 forks source link

Incorrect smearing and parameters for homogeneous Ecal smearing #205

Closed bschmookler closed 1 year ago

bschmookler commented 1 year ago

Environment: (where does this bug occur, have you tried other environments)

There is a difference between what is currently done for the homogeneous ECal smearing, and what we very recently put into Juggler here.

There was a typo in the previous Juggler implementation, which was fixed. It is now consistent with what is shown, for example, in slide 7 here.

In addition, on that same slide, the first parameter has units of E^(1/2); so for dd4hep/juggler, which use GeV as energy units, it should be 0.1/sqrt(1000) = 0.00316. This is what we recently put here.

These need to be made consistent in EICrecon in this file.

rymilton commented 1 year ago

Can this get addressed by somebody please? Issue #204 is going to be addressed by copying the corrected ecal files.

jizhongling commented 1 year ago

I verified that this issue has been fixed.

rymilton commented 1 year ago

Resolved with PR #236.