search

eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

Fix HCal backward endcap parameters #251

Closed DraTeots closed 1 year ago

DraTeots commented 2 years ago

As @lkosarz wrote:

These are my proposed updates:

'HCAL:hcalendcapnrawhits:capacityADC',                      'capacityBitsADC=10'
'HCAL:hcalendcapnrechits:capacityADC',                      'capacityBitsADC=10',

I only tested clustering distances in eta,phi, but this is not perfect. In fact, we need the dimension scaled one to be 1.5xsize of segment, so I think we need to set:

'HCAL:hcalendcapnislandprotoclusters:dimScaledLocalDistXY', '1.5,1.5', 
instead of just the local distance:
'HCAL:hcalendcapnislandprotoclusters:localDistXY',          '150,150',                        '* [mm]'
DraTeots commented 2 years ago

I am a bit confused about the second part. We now have: 

    ('HCAL:HcalEndcapNIslandProtoClusters:dimScaledLocalDistXY', '1.5,1.5',                        ''),
...
    ('HCAL:HcalEndcapNIslandProtoClusters:localDistXY',          '150,150',                        '* [mm]'),

How this should be changed?

lkosarz commented 2 years ago

To be honest me too. In the reconstruction script I was setting the version with eta and phi dimensions. Due to varying size of segments the localDistXY is no longer useful and the values doesn't matter I think. We need to tell the algorithm to use dimScaledLocalDistXY, which I don't see how to do here. The setting can remain as it is with 1.5xsize in X and Y. I may need to test it first though.

lkosarz commented 2 years ago

I also have additional request:

('HCAL:HcalEndcapNRawHits:dynamicRangeADC', '3.6GeV', ''), ('HCAL:HcalEndcapNRecHits:dynamicRangeADC', '3.6GeV', ''),

DraTeots commented 2 years ago

Ok, so in the end it is going to be as below. Is it correct? 

'HCAL:hcalendcapnrawhits:capacityADC',                      'capacityBitsADC=10'
'HCAL:hcalendcapnrechits:capacityADC',                      'capacityBitsADC=10',
'HCAL:hcalendcapnislandprotoclusters:dimScaledLocalDistXY', '1.5,1.5', 
'HCAL:hcalendcapnislandprotoclusters:localDistXY',          '150,150',                        '* [mm]'
'HCAL:HcalEndcapNRawHits:dynamicRangeADC',                  '3.6GeV', '',
'HCAL:HcalEndcapNRecHits:dynamicRangeADC',                  '3.6GeV', '',
lkosarz commented 2 years ago

Yes, this is correct. Just please add a "*" before "GeV"

'HCAL:HcalEndcapNRawHits:dynamicRangeADC', '3.6GeV', '', 'HCAL:HcalEndcapNRecHits:dynamicRangeADC', '3.6GeV', '',

DraTeots commented 2 years ago

@faustus123 David, sorry, could you pick this up? Have no internet at all.

DraTeots commented 2 years ago

Just need to put values above

lkosarz commented 2 years ago

Hi, I had a look at the changes and I see:

'HCAL:HcalEndcapNRawHits:dynamicRangeADC', '3.6*MeV', '',

it should be:

'HCAL:HcalEndcapNRawHits:dynamicRangeADC', '3.6*GeV', '',

We can update it later depending on the results.

I also noticed that merger is missing. We need to store hits and also merged hits for nHCal. The individual hits will be needed later to try to distinguish neutral/charged hadron showers. So we need to add a merger:

('HCAL:HcalEndcapNMergedHits:fields',                         'layer,slice',                    ''),
('HCAL:HcalEndcapNMergedHits:input_tag',                      'HcalEndcapNHits',              ''),
('HCAL:HcalEndcapNMergedHits:refs',                           '1,0',                            ''),

Also we need to make them propagate through the reconstruction chain, but I don't see a good example with the updated chain.

DraTeots commented 1 year ago

Not actual as reco_flags.py is gone