Open wdconinc opened 1 year ago
Related discussion:
https://github.com/eic/EICrecon/discussions/68
FYI Parameter names are not case sensitive (which is good). But indeed, there are lots of parameters with underscore '_' implying snake_case naming and other parameters rely on CamelCase. This bugs me a lot but before this ticket I thought I was the only one concerning and thinking about it as of a problem ;)
Note also that #68 was not concluded and no resolving policy is added to e.g. contribution.md. Thus it should be first decided and only then this ticket will become actual.
To be honest, I think this should not be a human decision. Too much opportunity for mistakes. There should be automatic parameter generation for all parameters that are available, with names that are unique and follow a specified set of rules.
To some degree it is automated. So the human decision is the last part and description. This pretty much work like "properties". If there was a policy defined in #68 we could fully automate it.
If, @wdconinc, you was supportive and allowed me to do https://github.com/eic/EICrecon/issues/296 - this would fix B0ECAL:B0ECalClusters:depthCorrection -> B0ECalClusters:LogLevel
As I would automate this part too. But now I don't want to go into each factory and fix it by hand.
~acts:InitLogLevel and acts_init:LogLevel
- is a bug.~ But it is there because #68 doesn't fully define scheme
Ok, there is no acts_init:LogLevel flag. There are two separate loggers: acts and acts_init, controlled by 2 flags: acts:LogLevel and acts:InitLogLevel. The logic behind it (from the documentation)
ACTS has two loggers controlled by two flags:
The reason for such level split is because it might be important to have a verbose init loggins, where geometry conversion is printed out, while there is no need for full print of reconstruction and wise versa.
But names of loggers (things that are written in [square brackets]) are acts
and atcs_init
Environment: (where does this bug occur, have you tried other environments)
main
for latest released): mainHEAD
for the most recent on git): HEADSteps to reproduce: (give a step by step account of how to trigger the bug)
Expected Result: (what do you expect when you execute the steps above)
Some consistency in parameter naming... preferably something that is automated and doesn't allow free-form strings...
Actual Result: (what do you get when you execute the steps above)
acts:InitLogLevel
andacts_init:LogLevel
:EEMC:B0ECalClusters:depthCorrection
indicates that theB0ECalClusters
somehow ended up in EEMC, while e.g.B0EcalClusters
is inB0ECAL
per above.Digi:SmearedFarForwardParticles:LogLevel
does not appear connected to any other algorithm with parameters that can be set.jana:plugin_path
uses lowercase, butJANA:STATUS_FNAME
uses uppercase.Reco:GeneratedParticles:LogLevel
with capitalR
, butreco:ReconstructedParticlesWithAssoc:LogLevel
with lowercaser
.HCAL
includes barrel, endcaps, and insert, butBEMC
andEEMC
are for barrel and endcaps separate.