eic / EICrecon

EIC Reconstruction - JANA based
https://eic.github.io/EICrecon
GNU Lesser General Public License v3.0
6 stars 29 forks source link

JetReconstruction: EDM improvements needed #724

Open veprbl opened 1 year ago

veprbl commented 1 year ago

The current implementation of the JetReconstruction algo was done before JANA had native PODIO collections, so both jets and its constituents are stored in the same collection, with a hack:

We first need to acknowledge that jets are not representable as edm4eic::ReconstructedParticle (e.g. they have "area"). Though even if they are for now, they don't belong in the same collection with the constituents. We also don't need to store constituents, instead we should just refer to the original ChargedReconstructedParticles/NeutralReconstructedParticles/MCParticles. That would not only allow to not duplicate the information unnecessarily, but also bring us closer to resolving a reported user issue: one currently can not relate jet constituents to the original track/cluster information.

cc @ruse-traveler @bspage912 @ShujieL

veprbl commented 1 year ago

See also #725