search

eic / HEPMC_Merger

A code used to to merge events from provided HEPMC files.
0 stars 0 forks source link

Accommodate time correlation with bunch crossings #1

Open kkauder opened 1 year ago

kkauder commented 1 year ago

Is your feature request related to a problem? Please describe. In the far backward region, Bremsstrahlung is a big issue and it's tightly correlated with bunch crossings. Currently, background is embedded with a uniform distribution.

Describe the solution you'd like Place background events at realistic timing, with realistic smearing.

Additional context Simon already gave a good writeup of the solution in his contribution here. https://indico.bnl.gov/event/20343/ This just needs to be converted to code, and the correct parameters used.

simonge commented 3 months ago

@wdconinc @veprbl I have a branch which moves the code towards more standard modular C++. This required a hack https://github.com/eic/HEPMC_Merger/commit/bf5acdc01391bd3aef5708a9eecffc5e6b6954c6 to work with the current version of HepMC3 libraries in eic-shell. I notice there is a new official release of HepMC3 3.3.0 available would we be able to test and update to this version in eic-shell? Previously using their main branch using a local build of the code I didn't require this hack but haven't tested again recently.

wdconinc commented 3 months ago

Updating upstream, https://github.com/spack/spack/pull/45617, then in the container.

wdconinc commented 3 months ago

HepMC3 3.3.0 merged into container, should roll out on cvmfs sometime tomorrow.