Open c-dilks opened 1 year ago
@wdconinc did something change in Geant4 or DD4hep such that the pattern of multiple /run/beamOn 1
calls (with varying gun directions, for example) now results in only a single event? Previously it ran as many events as /run/beamOn 1
calls.
@chchatte92 because of this issue, we don't really have CI working here on drich-dev
; this would need to be fixed if you still want to move simulate.py
to reconstruction_benchmarks
, or you'll have to make your own npsim
commands etc. there, or generate HEPMC files (however you prefer to run benchmarks is up to you).
EDIT well, CI does work here, this issue just means the eta and momentum scans all only process a single event.
I don't know specifically what could explain this. Geant4 formally starts a new G4Run with each /run/beamOn 1
call, and it might be that dd4hep now overwrite the previous run in the edm4hep file instead of adding events to a single run. Just a thought.
Could it be the change to PODIO frames?
That's one difference I see after comparing recent CI output to old (working) CI output:
All of the eta_scan
jobs have this problem.
Also I was a bit wrong about the lines Event # Begin event action...
incrementing, but I'm confident those linked old logs were from a workflow run in a working state, since they are from the PR merge commit that added these particular jobs.
The change would indeed likely have come with the update to the EDM4hep output plugin to write podio frames.
Environment: (where does this bug occur, have you tried other environments)
main
for latest released):main
Steps to reproduce: (give a step by step account of how to trigger the bug)
simulate.py -t 6 -k 5 -n 30
(eta scan, used in CI)Likely other tests (set with
-t
option) fail as well.simulate.py
generates a Geant4 macro file then runs it withnpsim
; the tests that now (likely) fail have the following pattern:Expected Result: (what do you expect when you execute the steps above)
An output file with many events, and
stdout
fromnpsim
includes (irrelevant lines omitted):Actual Result: (what do you get when you execute the steps above)
An output file with 1 event, and the corresponding
stdout
is repeated for event0
:See example CI log