eic / drich-dev

Resources for EPIC dRICH Development
3 stars 5 forks source link

fix: enable photon vertex cheating by default, for MC info access #109

Closed c-dilks closed 1 year ago

c-dilks commented 1 year ago

Briefly, what does this PR introduce?

enables cheatPhotonVertex for testing, so that drich-dev benchmarks will show the residual plots; note that this cheat mode does not impact PID, since it only allows knowledge of some MC to be read out, but not actually used. In other words, turning on this cheat mode does not actually "cheat" the PID... the results are the same when it is off.

This is in some sense a "fix", since we cannot otherwise check the residual plots.

Renames, including the enabled cheatPhotonVertex:

recon_irt.yaml -> recon_main.yaml, and is now used as the default
recon_irt_noise.yaml -> recon_noise.yaml

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes, makes residual benchmarks executed here in drich-dev useful

chchatte92 commented 1 year ago

We need the mc info in two places.

c-dilks commented 1 year ago

For now your changes can just go in reconstruction_benchmarks. This PR makes sure that when we run reconstruction_benchmarks from drich-dev, we can see everything we are used to seeing. This should hold us over until reconstruction_benchmarks is triggered by upstream PRs, or we migrate our benchmarks elsewhere (see Mattermost DMs).